Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39884 )
Change subject: Do not select USE_BLOBS ......................................................................
Do not select USE_BLOBS
The `USE_BLOBS` config only exists for idealistic reasons. If we would allow us to use blobs by default, we wouldn't need that option and could just always do it. It's generally debatable for the project as a whole, but not per board/subject.
Change-Id: I8591862699aef02e5a4ede32655fc82c44c97555 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/mainboard/pcengines/apu2/Kconfig M src/mainboard/system76/lemp9/Kconfig M src/mainboard/up/squared/Kconfig M src/security/intel/stm/Kconfig 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/39884/1
diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig index b434ddc..54f545a 100644 --- a/src/mainboard/pcengines/apu2/Kconfig +++ b/src/mainboard/pcengines/apu2/Kconfig @@ -26,7 +26,6 @@ select HAVE_MP_TABLE select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_8192 - select USE_BLOBS select GENERIC_SPD_BIN select MAINBOARD_HAS_LPC_TPM select SEABIOS_ADD_SERCON_PORT_FILE if PAYLOAD_SEABIOS diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index d814633..cc21ca9 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -19,7 +19,6 @@ select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SPD_READ_BY_WORD select SYSTEM_TYPE_LAPTOP - select USE_BLOBS select USE_LEGACY_8254_TIMER # Fix failure to boot GRUB
config MAINBOARD_DIR diff --git a/src/mainboard/up/squared/Kconfig b/src/mainboard/up/squared/Kconfig index 542e8c3..5104713 100644 --- a/src/mainboard/up/squared/Kconfig +++ b/src/mainboard/up/squared/Kconfig @@ -2,7 +2,6 @@
config BOARD_SPECIFIC_OPTIONS def_bool y - select USE_BLOBS select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select INTEL_GMA_HAVE_VBT diff --git a/src/security/intel/stm/Kconfig b/src/security/intel/stm/Kconfig index 618217f..f7dd363 100644 --- a/src/security/intel/stm/Kconfig +++ b/src/security/intel/stm/Kconfig @@ -3,7 +3,6 @@ default n depends on ENABLE_VMX depends on SMM_TSEG - select USE_BLOBS
help Enabling the STM will load a simple hypervisor into SMM that will
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39884 )
Change subject: Do not select USE_BLOBS ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39884 )
Change subject: Do not select USE_BLOBS ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39884/1/src/security/intel/stm/Kcon... File src/security/intel/stm/Kconfig:
https://review.coreboot.org/c/coreboot/+/39884/1/src/security/intel/stm/Kcon... PS1, Line 6: USE_BLOBS The STM binary is in the blobs repo, does it matter? Maybe depend on it?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39884 )
Change subject: Do not select USE_BLOBS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39884/1/src/security/intel/stm/Kcon... File src/security/intel/stm/Kconfig:
https://review.coreboot.org/c/coreboot/+/39884/1/src/security/intel/stm/Kcon... PS1, Line 6: USE_BLOBS
The STM binary is in the blobs repo, does it matter? Maybe depend on it?
We usually don't depend on USE_BLOBS, it would hide most of coreboot... making an exception here could cause some confusion, I guess?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39884 )
Change subject: Do not select USE_BLOBS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39884/1/src/security/intel/stm/Kcon... File src/security/intel/stm/Kconfig:
https://review.coreboot.org/c/coreboot/+/39884/1/src/security/intel/stm/Kcon... PS1, Line 6: USE_BLOBS
We usually don't depend on USE_BLOBS, it would hide most of coreboot... […]
*shrug*
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39884 )
Change subject: Do not select USE_BLOBS ......................................................................
Patch Set 1:
IMHO the whole USE_BLOBS thing makes the user experience worse. I'd still advocate for USE_BLOBS being default y; then the select USE_BLOBS can be removed from the boards, as it probably should. Didn't really get around to update my USE_BLOBS patch yet
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39884 )
Change subject: Do not select USE_BLOBS ......................................................................
Patch Set 1: Code-Review+2
37972 defaults USE_BLOBS to y and it's merged now, so this can be merged as well without breaking functionality
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39884 )
Change subject: Do not select USE_BLOBS ......................................................................
Do not select USE_BLOBS
The `USE_BLOBS` config only exists for idealistic reasons. If we would allow us to use blobs by default, we wouldn't need that option and could just always do it. It's generally debatable for the project as a whole, but not per board/subject.
Change-Id: I8591862699aef02e5a4ede32655fc82c44c97555 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39884 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/pcengines/apu2/Kconfig M src/mainboard/system76/lemp9/Kconfig M src/mainboard/up/squared/Kconfig M src/security/intel/stm/Kconfig 4 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig index 1915cc2..4321c5c 100644 --- a/src/mainboard/pcengines/apu2/Kconfig +++ b/src/mainboard/pcengines/apu2/Kconfig @@ -26,7 +26,6 @@ select HAVE_MP_TABLE select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_8192 - select USE_BLOBS select GENERIC_SPD_BIN select MAINBOARD_HAS_LPC_TPM select SEABIOS_ADD_SERCON_PORT_FILE if PAYLOAD_SEABIOS diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index d814633..cc21ca9 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -19,7 +19,6 @@ select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SPD_READ_BY_WORD select SYSTEM_TYPE_LAPTOP - select USE_BLOBS select USE_LEGACY_8254_TIMER # Fix failure to boot GRUB
config MAINBOARD_DIR diff --git a/src/mainboard/up/squared/Kconfig b/src/mainboard/up/squared/Kconfig index 542e8c3..5104713 100644 --- a/src/mainboard/up/squared/Kconfig +++ b/src/mainboard/up/squared/Kconfig @@ -2,7 +2,6 @@
config BOARD_SPECIFIC_OPTIONS def_bool y - select USE_BLOBS select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select INTEL_GMA_HAVE_VBT diff --git a/src/security/intel/stm/Kconfig b/src/security/intel/stm/Kconfig index 618217f..f7dd363 100644 --- a/src/security/intel/stm/Kconfig +++ b/src/security/intel/stm/Kconfig @@ -3,7 +3,6 @@ default n depends on ENABLE_VMX depends on SMM_TSEG - select USE_BLOBS
help Enabling the STM will load a simple hypervisor into SMM that will
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39884 )
Change subject: Do not select USE_BLOBS ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2353 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2352 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2351
Please note: This test is under development and might not be accurate at all!
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39884 )
Change subject: Do not select USE_BLOBS ......................................................................
Patch Set 2: Code-Review+2
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Felix Held (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)