Attention is currently required from: Sean Rhodes, Martin L Roth, Matt DeVillier, Stefan Reinauer.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74176 )
Change subject: payloads/edk2: Set max variable size to 0x8000 for SMMSTORE
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
Just as your edk2 patch wont make it into edk2 master
Why not squash it into the SMMSTORE patch? I'm starting to use:
```
!if $(VARIABLE_SUPPORT) == "SMMSTORE"
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x8000
!else
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x10000
!endif
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10d2a5a0c1d729d83e0b62bb9430863317b883cc
Gerrit-Change-Number: 74176
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 03 Apr 2023 15:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Gerrit-MessageType: comment