Attention is currently required from: Andrey Petrov, Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Kapil Porwal, Ronak Kanabar, Sean Rhodes, Subrata Banik.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81618?usp=email )
Change subject: lib: Refactor bmp_load_logo() implementation
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/soc/amd/mendocino/fsp_s_params.c:
https://review.coreboot.org/c/coreboot/+/81618/comment/5b9a1a70_11e17dbb :
PS4, Line 59: supd->FspsConfig.logo_bmp_buffer = (uint32_t)(uintptr_t)bmp_load_logo(&logo_size);
I'm curious why the logo size isn't updated in the FspsConfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81618?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I14bc54670a67980ec93bc366b274832d1f959e50
Gerrit-Change-Number: 81618
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 05 Apr 2024 04:43:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment