Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37729 )
Change subject: src/mb/Kconfig: add BOARD_ROMSIZE_KB_5120 ......................................................................
src/mb/Kconfig: add BOARD_ROMSIZE_KB_5120
Mainboards exist with a 4+1 MiB flash chip combination.
Change-Id: I214553a2c70e1a4a0e4d972fee5e524b609bb1e0 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/Kconfig 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/37729/1
diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig index 97086b7..a3895e9 100644 --- a/src/mainboard/Kconfig +++ b/src/mainboard/Kconfig @@ -28,6 +28,8 @@ bool config BOARD_ROMSIZE_KB_4096 bool +config BOARD_ROMSIZE_KB_5120 + bool config BOARD_ROMSIZE_KB_6144 bool config BOARD_ROMSIZE_KB_8192 @@ -53,6 +55,7 @@ default COREBOOT_ROMSIZE_KB_1024 if BOARD_ROMSIZE_KB_1024 default COREBOOT_ROMSIZE_KB_2048 if BOARD_ROMSIZE_KB_2048 default COREBOOT_ROMSIZE_KB_4096 if BOARD_ROMSIZE_KB_4096 + default COREBOOT_ROMSIZE_KB_5120 if BOARD_ROMSIZE_KB_5120 default COREBOOT_ROMSIZE_KB_6144 if BOARD_ROMSIZE_KB_6144 default COREBOOT_ROMSIZE_KB_8192 if BOARD_ROMSIZE_KB_8192 default COREBOOT_ROMSIZE_KB_10240 if BOARD_ROMSIZE_KB_10240 @@ -101,6 +104,11 @@ help Choose this option if you have a 4096 KB (4 MB) ROM chip.
+config COREBOOT_ROMSIZE_KB_5120 + bool "5120 KB (5 MB)" + help + Choose this option if you have a 5120 KB (5 MB) ROM chip. + config COREBOOT_ROMSIZE_KB_6144 bool "6144 KB (6 MB)" help @@ -148,6 +156,7 @@ default 1024 if COREBOOT_ROMSIZE_KB_1024 default 2048 if COREBOOT_ROMSIZE_KB_2048 default 4096 if COREBOOT_ROMSIZE_KB_4096 + default 5120 if COREBOOT_ROMSIZE_KB_5120 default 6144 if COREBOOT_ROMSIZE_KB_6144 default 8192 if COREBOOT_ROMSIZE_KB_8192 default 10240 if COREBOOT_ROMSIZE_KB_10240 @@ -166,6 +175,7 @@ default 0x100000 if COREBOOT_ROMSIZE_KB_1024 default 0x200000 if COREBOOT_ROMSIZE_KB_2048 default 0x400000 if COREBOOT_ROMSIZE_KB_4096 + default 0x500000 if COREBOOT_ROMSIZE_KB_5120 default 0x600000 if COREBOOT_ROMSIZE_KB_6144 default 0x800000 if COREBOOT_ROMSIZE_KB_8192 default 0xa00000 if COREBOOT_ROMSIZE_KB_10240
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37729 )
Change subject: src/mb/Kconfig: add BOARD_ROMSIZE_KB_5120 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37729/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37729/1//COMMIT_MSG@9 PS1, Line 9: exist I don't see any ;) any plans to add one?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37729 )
Change subject: src/mb/Kconfig: add BOARD_ROMSIZE_KB_5120 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37729/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37729/1//COMMIT_MSG@9 PS1, Line 9: exist
I don't see any ;) any plans to add one?
Um, you didn't look hard enough then... CB:30651 has existed for almost a year.
Sure, it might have not received much attention, but that's about to change.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37729 )
Change subject: src/mb/Kconfig: add BOARD_ROMSIZE_KB_5120 ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37729 )
Change subject: src/mb/Kconfig: add BOARD_ROMSIZE_KB_5120 ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37729/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37729/1//COMMIT_MSG@9 PS1, Line 9: exist
Um, you didn't look hard enough then... CB:30651 has existed for almost a year. […]
Well, I only looked on this branch :-P
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37729 )
Change subject: src/mb/Kconfig: add BOARD_ROMSIZE_KB_5120 ......................................................................
src/mb/Kconfig: add BOARD_ROMSIZE_KB_5120
Mainboards exist with a 4+1 MiB flash chip combination.
Change-Id: I214553a2c70e1a4a0e4d972fee5e524b609bb1e0 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37729 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/Kconfig 1 file changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig index 97086b7..a3895e9 100644 --- a/src/mainboard/Kconfig +++ b/src/mainboard/Kconfig @@ -28,6 +28,8 @@ bool config BOARD_ROMSIZE_KB_4096 bool +config BOARD_ROMSIZE_KB_5120 + bool config BOARD_ROMSIZE_KB_6144 bool config BOARD_ROMSIZE_KB_8192 @@ -53,6 +55,7 @@ default COREBOOT_ROMSIZE_KB_1024 if BOARD_ROMSIZE_KB_1024 default COREBOOT_ROMSIZE_KB_2048 if BOARD_ROMSIZE_KB_2048 default COREBOOT_ROMSIZE_KB_4096 if BOARD_ROMSIZE_KB_4096 + default COREBOOT_ROMSIZE_KB_5120 if BOARD_ROMSIZE_KB_5120 default COREBOOT_ROMSIZE_KB_6144 if BOARD_ROMSIZE_KB_6144 default COREBOOT_ROMSIZE_KB_8192 if BOARD_ROMSIZE_KB_8192 default COREBOOT_ROMSIZE_KB_10240 if BOARD_ROMSIZE_KB_10240 @@ -101,6 +104,11 @@ help Choose this option if you have a 4096 KB (4 MB) ROM chip.
+config COREBOOT_ROMSIZE_KB_5120 + bool "5120 KB (5 MB)" + help + Choose this option if you have a 5120 KB (5 MB) ROM chip. + config COREBOOT_ROMSIZE_KB_6144 bool "6144 KB (6 MB)" help @@ -148,6 +156,7 @@ default 1024 if COREBOOT_ROMSIZE_KB_1024 default 2048 if COREBOOT_ROMSIZE_KB_2048 default 4096 if COREBOOT_ROMSIZE_KB_4096 + default 5120 if COREBOOT_ROMSIZE_KB_5120 default 6144 if COREBOOT_ROMSIZE_KB_6144 default 8192 if COREBOOT_ROMSIZE_KB_8192 default 10240 if COREBOOT_ROMSIZE_KB_10240 @@ -166,6 +175,7 @@ default 0x100000 if COREBOOT_ROMSIZE_KB_1024 default 0x200000 if COREBOOT_ROMSIZE_KB_2048 default 0x400000 if COREBOOT_ROMSIZE_KB_4096 + default 0x500000 if COREBOOT_ROMSIZE_KB_5120 default 0x600000 if COREBOOT_ROMSIZE_KB_6144 default 0x800000 if COREBOOT_ROMSIZE_KB_8192 default 0xa00000 if COREBOOT_ROMSIZE_KB_10240
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)