Change in ...coreboot[master]: lib/romstage_stack.c: Remove unused function

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33936

Change subject: lib/romstage_stack.c: Remove unused function
......................................................................

lib/romstage_stack.c: Remove unused function

Change-Id: I1e66ff3fe7462dfeae2a7ce7e3a8083cf90a15f9
Signed-off-by: Arthur Heymans 
---
M src/include/program_loading.h
M src/lib/romstage_stack.c
2 files changed, 0 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33936/1

diff --git a/src/include/program_loading.h b/src/include/program_loading.h
index 7be59e2..5644f1b 100644
--- a/src/include/program_loading.h
+++ b/src/include/program_loading.h
@@ -176,7 +176,6 @@
 /* Determine where stack for ramstage loader is located. */
 enum { ROMSTAGE_STACK_CBMEM, ROMSTAGE_STACK_LOW_MEM };
 uintptr_t romstage_ram_stack_base(size_t size, int src);
-uintptr_t romstage_ram_stack_top(void);
 uintptr_t romstage_ram_stack_bottom(void);

/* Backup OS memory to CBMEM_ID_RESUME on ACPI S3 resume path,
diff --git a/src/lib/romstage_stack.c b/src/lib/romstage_stack.c
index ed6f09b..d085f75 100644
--- a/src/lib/romstage_stack.c
+++ b/src/lib/romstage_stack.c
@@ -38,14 +38,3 @@
    return romstage_ram_stack_base(ROMSTAGE_RAM_STACK_SIZE,
    	ROMSTAGE_STACK_CBMEM);
 }
-
-uintptr_t romstage_ram_stack_top(void)
-{
-	uintptr_t stack_top = romstage_ram_stack_base(ROMSTAGE_RAM_STACK_SIZE,
-		ROMSTAGE_STACK_CBMEM);
-	stack_top += ROMSTAGE_RAM_STACK_SIZE;
-
-	/* Make it aligned to a 8-byte boundary. */
-	stack_top = ALIGN_DOWN(stack_top, 8);
-	return stack_top;
-}

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33936 )

Change subject: lib/romstage_stack.c: Remove unused function
......................................................................

Patch Set 1: Code-Review+1

Change in ...coreboot[master]: lib/romstage_stack.c: Remove unused functions

[Arthur Heymans (Code Review)]

Hello Kyösti Mälkki, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33936

to look at the new patch set (#2).

Change subject: lib/romstage_stack.c: Remove unused functions
......................................................................

lib/romstage_stack.c: Remove unused functions

ROMSTAGE_STACK_LOW_MEM is unused.

Change-Id: I1e66ff3fe7462dfeae2a7ce7e3a8083cf90a15f9
Signed-off-by: Arthur Heymans 
---
M src/include/program_loading.h
M src/lib/romstage_stack.c
2 files changed, 3 insertions(+), 27 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33936/2

Change in ...coreboot[master]: lib/romstage_stack.c: Remove unused functions

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33936 )

Change subject: lib/romstage_stack.c: Remove unused functions
......................................................................

Patch Set 2:

Let's just remove _top() and _bottom() now.
I have to look into it, but AGESA/binaryPI probably no longer really needs _base().

See CB:15473 why LOW_MEM was introduced. We can push the remaining code under cpu/amd and hope that fam10-15 hits deprecation (lack of RELOCATABLE_RAMSTAGE & POSTCAR).

Change in ...coreboot[master]: lib/romstage_stack.c: Remove unused functions

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded a new patch set (#3) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/33936 )

Change subject: lib/romstage_stack.c: Remove unused functions
......................................................................

lib/romstage_stack.c: Remove unused functions

Change-Id: I1e66ff3fe7462dfeae2a7ce7e3a8083cf90a15f9
Signed-off-by: Arthur Heymans 
---
M src/include/program_loading.h
M src/lib/romstage_stack.c
2 files changed, 0 insertions(+), 18 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33936/3

Change in ...coreboot[master]: lib/romstage_stack.c: Remove unused functions

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded a new patch set (#4) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/33936 )

Change subject: lib/romstage_stack.c: Remove unused functions
......................................................................

lib/romstage_stack.c: Remove unused functions

Change-Id: I1e66ff3fe7462dfeae2a7ce7e3a8083cf90a15f9
Signed-off-by: Arthur Heymans 
---
M src/include/program_loading.h
M src/lib/romstage_stack.c
2 files changed, 0 insertions(+), 19 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33936/4

Change in ...coreboot[master]: lib/romstage_stack.c: Remove unused functions

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33936 )

Change subject: lib/romstage_stack.c: Remove unused functions
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: lib/romstage_stack.c: Remove unused functions

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33936 )

Change subject: lib/romstage_stack.c: Remove unused functions
......................................................................

lib/romstage_stack.c: Remove unused functions

Change-Id: I1e66ff3fe7462dfeae2a7ce7e3a8083cf90a15f9
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33936
Reviewed-by: Aaron Durbin 
Tested-by: build bot (Jenkins) 
---
M src/include/program_loading.h
M src/lib/romstage_stack.c
2 files changed, 0 insertions(+), 19 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved

diff --git a/src/include/program_loading.h b/src/include/program_loading.h
index 7be59e2..223fc0b 100644
--- a/src/include/program_loading.h
+++ b/src/include/program_loading.h
@@ -176,8 +176,6 @@
 /* Determine where stack for ramstage loader is located. */
 enum { ROMSTAGE_STACK_CBMEM, ROMSTAGE_STACK_LOW_MEM };
 uintptr_t romstage_ram_stack_base(size_t size, int src);
-uintptr_t romstage_ram_stack_top(void);
-uintptr_t romstage_ram_stack_bottom(void);

/* Backup OS memory to CBMEM_ID_RESUME on ACPI S3 resume path,
  * if ramstage overwrites low memory. */
diff --git a/src/lib/romstage_stack.c b/src/lib/romstage_stack.c
index ed6f09b..4fe1459 100644
--- a/src/lib/romstage_stack.c
+++ b/src/lib/romstage_stack.c
@@ -32,20 +32,3 @@
    	return CONFIG_RAMTOP - size;
    return 0;
 }
-
-uintptr_t romstage_ram_stack_bottom(void)
-{
-	return romstage_ram_stack_base(ROMSTAGE_RAM_STACK_SIZE,
-		ROMSTAGE_STACK_CBMEM);
-}
-
-uintptr_t romstage_ram_stack_top(void)
-{
-	uintptr_t stack_top = romstage_ram_stack_base(ROMSTAGE_RAM_STACK_SIZE,
-		ROMSTAGE_STACK_CBMEM);
-	stack_top += ROMSTAGE_RAM_STACK_SIZE;
-
-	/* Make it aligned to a 8-byte boundary. */
-	stack_top = ALIGN_DOWN(stack_top, 8);
-	return stack_top;
-}