[M] Change in coreboot[master]: mb/google/myst: Enable AP <-> GSC communication - coreboot-gerrit

3 Apr 2023


      Attention is currently required from: Raul Rangel, Jon Murphy, Tim Van Patten, Karthik Ramasubramanian.
Mark Hasemeyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74111 )
Change subject: mb/google/myst: Enable AP <-> GSC communication
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/myst/Kconfig:
https://review.coreboot.org/c/coreboot/+/74111/comment/6882d63a_898af3dc 
PS4, Line 38: 	default 0x03
Should this be 0x2?
File src/mainboard/google/myst/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74111/comment/ebe6b051_af0a4329 
PS4, Line 136: 			device i2c 50 on end
Should this be GPIO_84?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e235356b252a7b68a42da128ffd3189a829f117
Gerrit-Change-Number: 74111
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer markhas@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:30:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment