Attention is currently required from: Subrata Banik, Dinesh Gehlot, Paul Menzel, Kapil Porwal.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74995 )
Change subject: soc/intel/cmd/block/cse: Store CSE version in CMOS memory
......................................................................
Patch Set 20: Code-Review+1
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74995/comment/923018c2_f22c4e3a
PS9, Line 1233: write current ISH version to CBMEM memory.
Yes, The ISH version must be stored in both CMOS and CBMEM. […]
The CBMEM version of ISH is used by the exposed API get_ish_version() to provide the ISH version to its users.
Can not get_ish_version() read the ISH version from CMOS and share with it's users?
I mean can't you avoid relying on CBMEM here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74995
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd0ee19575683691c0a82a291e1fd3b2ffb11786
Gerrit-Change-Number: 74995
Gerrit-PatchSet: 20
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 22 May 2023 07:51:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment