Change in coreboot[master]: mb/google/guybrush: Fix EC SCI configuration - coreboot-gerrit

26 Apr 2021


      Attention is currently required from: Eric Peers.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52673 )
Change subject: mb/google/guybrush: Fix EC SCI configuration
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52673/comment/031978d7_7f64bf6f 
PS2, Line 14: Cezanne has added a new event source that directly exposes the SCI bit.
...
does this mean we should abstract this logic to chipset rather than mainboard? […]
I wouldn't move this to chipset since it's dependent on the EC implementation. Yeah, this is needed for mancomb. EricR has been keeping mancomb in sync with guybrush.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52673
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I764b9ec202376d5124331a320767cbf79371dc07
Gerrit-Change-Number: 52673
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Peers epeers@google.com
Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Eric Peers epeers@google.com
Gerrit-Comment-Date: Mon, 26 Apr 2021 19:35:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Peers epeers@google.com
Gerrit-MessageType: comment