Attention is currently required from: Alexander Couzens, Angel Pons, Martin L Roth.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76962?usp=email )
Change subject: SNB+MRC boards: Do not redo PEI data struct in hook
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/butterfly/early_init.c:
https://review.coreboot.org/c/coreboot/+/76962/comment/e83e04ed_291d729a :
PS5, Line 100: /* TODO: Native raminit only uses 1333. Reconcile. */
Acknowledged
I actually ran into the same problem as those Google boards on my p8z77-m with DDR3-1600 rated memory. None of them can boot at max_mem_clock 800mhz. Had to reduce it to 666 using your ternary and then somehow my best memory achieved same throughput as full speed. Maybe because it is running CL8 instead of CL9 at 800mhz clock...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76962?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie349a8f400eecca3cdbc196ea0790aebe0549e39
Gerrit-Change-Number: 76962
Gerrit-PatchSet: 5
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 04 Oct 2023 04:15:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Gerrit-MessageType: comment