Change in coreboot[master]: soc/intel/skl + cpu/intel/common: move AES-NI locking to common cpu code
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46272 )
Change subject: soc/intel/skl + cpu/intel/common: move AES-NI locking to common cpu code ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.h File src/include/cpu/intel/msr.h:
https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.h... PS4, Line 8: #define MSR_FEATURE_CONFIG 0x13c
did you mean "the other header[s]"? […]
I meant the one that is close to this change and was used in the moved code `src/soc/intel/common/block/include/intelblocks/msr.h`.
Not a requirement, though.
https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.h... PS4, Line 9: #define AESNI_LOCK_BIT 0
Hmm, indeed it's only used a few times in cpu/intel and once in soc/intel. […]
I would replace msr_set_bit() with _unset and _set versions like we have them for other registers like CB:42134.
-
Nico Huber (Code Review)