Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34546 )
Change subject: soc/intel/broadwell: Fix case of SA_DEV_ROOT ......................................................................
soc/intel/broadwell: Fix case of SA_DEV_ROOT
Commit 71756c2 soc/intel: Expand SA_DEV_ROOT for ramstage removed SA_DEV_ROOT expanding to device pointer. We missed the case here, use __SIMPLE_DEVICE__ instead for the file.
Change-Id: I4331298837afa3b8c8321da610f99f8f5fa54737 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/broadwell/memmap.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/34546/1
diff --git a/src/soc/intel/broadwell/memmap.c b/src/soc/intel/broadwell/memmap.c index 7443121..836fda8 100644 --- a/src/soc/intel/broadwell/memmap.c +++ b/src/soc/intel/broadwell/memmap.c @@ -13,6 +13,8 @@ * GNU General Public License for more details. */
+#define __SIMPLE_DEVICE__ + #include <device/pci_ops.h> #include <cbmem.h> #include <device/pci.h>
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34546 )
Change subject: soc/intel/broadwell: Fix case of SA_DEV_ROOT ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34546 )
Change subject: soc/intel/broadwell: Fix case of SA_DEV_ROOT ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34546 )
Change subject: soc/intel/broadwell: Fix case of SA_DEV_ROOT ......................................................................
soc/intel/broadwell: Fix case of SA_DEV_ROOT
Commit 71756c2 soc/intel: Expand SA_DEV_ROOT for ramstage removed SA_DEV_ROOT expanding to device pointer. We missed the case here, use __SIMPLE_DEVICE__ instead for the file.
Change-Id: I4331298837afa3b8c8321da610f99f8f5fa54737 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34546 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/broadwell/memmap.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/memmap.c b/src/soc/intel/broadwell/memmap.c index 7443121..836fda8 100644 --- a/src/soc/intel/broadwell/memmap.c +++ b/src/soc/intel/broadwell/memmap.c @@ -13,6 +13,8 @@ * GNU General Public License for more details. */
+#define __SIMPLE_DEVICE__ + #include <device/pci_ops.h> #include <cbmem.h> #include <device/pci.h>
-
Furquan Shaikh (Code Review) -
Kyösti Mälkki (Code Review)
-
Martin Roth (Code Review)
-
Nico Huber (Code Review)