Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, Aaron Durbin, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54098 )
Change subject: soc/intel/common: OEM variables support for DPTF
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/acpi/acpi/globalnvs.asl:
https://review.coreboot.org/c/coreboot/+/54098/comment/7035abf7_9dc68738
PS5, Line 28: ODV0, 8, // Oem Design Variable 0
: ODV1, 8, // Oem Design Variable 1
: ODV2, 8, // Oem Design Variable 2
: ODV3, 8, // Oem Design Variable 3
: ODV4, 8, // Oem Design Variable 4
: ODV5, 8, // Oem Design Variable 5
Why do these have to live in GNVS?
Based on an event these values might get updated and to transfer these values, we need to store these values in gnvs to be supplied until someone can query and read them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54098
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79fbf00521d54e66b6cd7d95b026a76fd3a4394b
Gerrit-Change-Number: 54098
Gerrit-PatchSet: 5
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 15 Jun 2021 18:01:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment