Change in ...coreboot[master]: mb/google/hatch/var/kohaku: Skip UART0 config in FSP

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Furquan Shaikh (Code Review)

23 Apr 2019 23 Apr '19

6:46 a.m.

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32398

Change subject: mb/google/hatch/var/kohaku: Skip UART0 config in FSP ......................................................................

mb/google/hatch/var/kohaku: Skip UART0 config in FSP

Similar to hatch(CB:32278), this change sets SerialIo config for UART0 to PchSerialIoSkipInit to skip initialization in FSP.

BUG=b:130310626

Change-Id: Ia25b45811be26d55fc0019e4cd22eb7310b5a4c4 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/32398/1

diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 6e6414e..d564918 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -10,9 +10,12 @@ [PchSerialIoIndexSPI0] = PchSerialIoPci, [PchSerialIoIndexSPI1] = PchSerialIoPci, [PchSerialIoIndexSPI2] = PchSerialIoDisabled, - [PchSerialIoIndexUART0] = PchSerialIoPci, + [PchSerialIoIndexUART0] = PchSerialIoSkipInit, [PchSerialIoIndexUART1] = PchSerialIoDisabled, [PchSerialIoIndexUART2] = PchSerialIoDisabled, }"

+ device domain 0 on + end + end

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Furquan Shaikh (Code Review)

23 Apr 23 Apr

6:47 a.m.

Hello Kane Chen, Tim Wawrzynczak, Shelley Chen,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32398

to look at the new patch set (#2).

Change subject: mb/google/hatch/var/kohaku: Skip UART0 config in FSP ......................................................................

mb/google/hatch/var/kohaku: Skip UART0 config in FSP

Similar to hatch(CB:32278), this change sets SerialIo config for UART0 to PchSerialIoSkipInit to skip initialization in FSP.

This change also adds a device to kohaku override tree to ensure that the settings in it take effect.

BUG=b:130310626

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/32398/2

Kane Chen (Code Review)

10:39 a.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32398 )

Change subject: mb/google/hatch/var/kohaku: Skip UART0 config in FSP ......................................................................

Patch Set 2:

Hi Fuquan, we also need this change. Do you think this require another commit?

thanks.

diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index d564918..606a3b5 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -15,6 +15,13 @@ chip soc/intel/cannonlake [PchSerialIoIndexUART2] = PchSerialIoDisabled, }"

+ register "common_soc_config" = "{ + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + }" +

-- To view, visit https://review.coreboot.org/c/coreboot/+/32398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia25b45811be26d55fc0019e4cd22eb7310b5a4c4 Gerrit-Change-Number: 32398 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Grace Kao grace.kao@intel.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Grace Kao grace.kao@intel.corp-partner.google.com Gerrit-CC: Kane Chen kane.chen@intel.corp-partner.google.com Gerrit-CC: Philip Chen philipchen@google.com Gerrit-CC: shkim sh_.kim@samsung.com Gerrit-Comment-Date: Tue, 23 Apr 2019 10:39:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

1:52 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32398 )

Change subject: mb/google/hatch/var/kohaku: Skip UART0 config in FSP ......................................................................

Patch Set 2:

...

Patch Set 2:

Hi Fuquan, we also need this change. Do you think this require another commit?

thanks.

diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index d564918..606a3b5 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -15,6 +15,13 @@ chip soc/intel/cannonlake [PchSerialIoIndexUART2] = PchSerialIoDisabled, }"
  register "common_soc_config" = "{
         .gspi[0] = {
                 .speed_mhz = 1,
                 .early_init = 1,
         },
  }"

Done: https://review.coreboot.org/c/coreboot/+/32402

-- To view, visit https://review.coreboot.org/c/coreboot/+/32398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia25b45811be26d55fc0019e4cd22eb7310b5a4c4 Gerrit-Change-Number: 32398 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Grace Kao grace.kao@intel.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Grace Kao grace.kao@intel.corp-partner.google.com Gerrit-CC: Kane Chen kane.chen@intel.corp-partner.google.com Gerrit-CC: Philip Chen philipchen@google.com Gerrit-CC: shkim sh_.kim@samsung.com Gerrit-Comment-Date: Tue, 23 Apr 2019 13:52:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Duncan Laurie (Code Review)

24 Apr 24 Apr

3:53 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32398 )

Change subject: mb/google/hatch/var/kohaku: Skip UART0 config in FSP ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia25b45811be26d55fc0019e4cd22eb7310b5a4c4 Gerrit-Change-Number: 32398 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Grace Kao grace.kao@intel.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Grace Kao grace.kao@intel.corp-partner.google.com Gerrit-CC: Kane Chen kane.chen@intel.corp-partner.google.com Gerrit-CC: Philip Chen philipchen@google.com Gerrit-CC: shkim sh_.kim@samsung.com Gerrit-Comment-Date: Wed, 24 Apr 2019 15:53:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

4:23 p.m.

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32398 )

Change subject: mb/google/hatch/var/kohaku: Skip UART0 config in FSP ......................................................................

mb/google/hatch/var/kohaku: Skip UART0 config in FSP

Similar to hatch(CB:32278), this change sets SerialIo config for UART0 to PchSerialIoSkipInit to skip initialization in FSP.

This change also adds a device to kohaku override tree to ensure that the settings in it take effect.

BUG=b:130310626

Change-Id: Ia25b45811be26d55fc0019e4cd22eb7310b5a4c4 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32398 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 4 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved

+ device domain 0 on + end + end

-- To view, visit https://review.coreboot.org/c/coreboot/+/32398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia25b45811be26d55fc0019e4cd22eb7310b5a4c4 Gerrit-Change-Number: 32398 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Grace Kao grace.kao@intel.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Grace Kao grace.kao@intel.corp-partner.google.com Gerrit-CC: Kane Chen kane.chen@intel.corp-partner.google.com Gerrit-CC: Philip Chen philipchen@google.com Gerrit-CC: shkim sh_.kim@samsung.com Gerrit-MessageType: merged

1986

days inactive

1987

days old

coreboot-gerrit@coreboot.org

5 comments

3 participants

tags (0)

participants (3)

Duncan Laurie (Code Review)
Furquan Shaikh (Code Review)
Kane Chen (Code Review)