Change in coreboot[master]: mb/google/dedede/var/boten: Add LTE power on/off sequence - coreboot-gerrit

29 Mar 2021


      Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44588 )
Change subject: mb/google/dedede/var/boten: Add LTE power on/off sequence
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/google/dedede/variants/boten/variant.c:
https://review.coreboot.org/c/coreboot/+/44588/comment/d9315ed2_26465d23 
PS12, Line 19: 	 * the situation where it is stuffed.
...
Is this comment a TODO? I don't see any references to fw_config.
Currently all SKUs of the boten board have LTE. So this comment can be removed.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44588
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6d5d21ce5267f147b332a4c9b01a29b3b8ccfb8
Gerrit-Change-Number: 44588
Gerrit-PatchSet: 12
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Alec Wang alec.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Henry Sun henrysun@google.com
Gerrit-Reviewer: Marco Chen marcochen@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Peichao Wang pwang12@lenovo.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Mon, 29 Mar 2021 17:03:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment