Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35100 )
Change subject: mb/asrock/h110m: add missing pci devices to tree ......................................................................
mb/asrock/h110m: add missing pci devices to tree
These devices turn on after initializing the Intel FSP
Change-Id: I0a15537b6ba56fcf63267641ef2219f24d25d9c4 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35100/1
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 24409a1..f51f477 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -273,6 +273,8 @@ device pci 02.0 on # Integrated Graphics Device subsystemid 0x1849 0x1912 end + device pci 04.0 on # Thermal Subsystem + device pci 08.0 on # Gaussian Mixture Model device pci 14.0 on # USB xHCI subsystemid 0x1849 0xa131 end
Maxim Polyakov has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/35100 )
Change subject: mb/asrock/h110m: add missing pci devices to tree ......................................................................
mb/asrock/h110m: add missing pci devices to tree
These devices are enabled after initializing in the FSP
Change-Id: I0a15537b6ba56fcf63267641ef2219f24d25d9c4 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35100/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35100
to look at the new patch set (#3).
Change subject: mb/asrock/h110m: add missing pci devices to tree ......................................................................
mb/asrock/h110m: add missing pci devices to tree
These devices are enabled after initializing in the FSP
Change-Id: I0a15537b6ba56fcf63267641ef2219f24d25d9c4 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35100/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35100 )
Change subject: mb/asrock/h110m: add missing pci devices to tree ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35100/3/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35100/3/src/mainboard/asrock/h110m/... PS3, Line 277: d You can disable that, it's meant to be used for speech recognition I think.
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35100
to look at the new patch set (#4).
Change subject: mb/asrock/h110m: add missing pci devices to tree ......................................................................
mb/asrock/h110m: add missing pci devices to tree
These devices are enabled after initializing in the FSP
Change-Id: I0a15537b6ba56fcf63267641ef2219f24d25d9c4 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35100/4
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35100
to look at the new patch set (#8).
Change subject: mb/asrock/h110m: add missing pci devices to tree ......................................................................
mb/asrock/h110m: add missing pci devices to tree
These devices are enabled after initializing in the FSP
Change-Id: I0a15537b6ba56fcf63267641ef2219f24d25d9c4 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35100/8
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35100
to look at the new patch set (#9).
Change subject: mb/asrock/h110m: add missing pci devices to tree ......................................................................
mb/asrock/h110m: add missing pci devices to tree
These devices are enabled after initializing in the FSP
Change-Id: I0a15537b6ba56fcf63267641ef2219f24d25d9c4 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35100/9
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35100 )
Change subject: mb/asrock/h110m: add missing pci devices to tree ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35100/3/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35100/3/src/mainboard/asrock/h110m/... PS3, Line 277: d
You can disable that, it's meant to be used for speech recognition I think.
This device will be enabled after initialization in the FSP, regardless of the settings in the device tree. I do not yet know how to disable this using the FSP options. Maybe try to disable this device in the DEVEN register (Device Enable - Offset: [B:0, D:0, F:0] + 54h)?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35100 )
Change subject: mb/asrock/h110m: add missing pci devices to tree ......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35100/3/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35100/3/src/mainboard/asrock/h110m/... PS3, Line 277: d
This device will be enabled after initialization in the FSP, regardless of the settings in the devic […]
Disabling it on the devicetree should be enough, I guess.
In any case, you should be able to disable the Gaussian Mixture Model (GMM) using the "GmmEnable" UPD on FSP-S. Note that the UPD name never referenced in coreboot code, but it appears here:
3rdparty/fsp/KabylakeFspBinPkg/Include/FspsUpd.h
AmberLake also has that UPD, but Cannonlake and Coffelake renamed it to "GnaEnable".
I never tried using the DEVEN register. Feel free to experiment :)
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35100 )
Change subject: mb/asrock/h110m: add missing pci devices to tree ......................................................................
Patch Set 11:
(1 comment)
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35100/3/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35100/3/src/mainboard/asrock/h110m/... PS3, Line 277: d
Disabling it on the devicetree should be enough, I guess. […]
Thanks for your help. Sometimes it seems to me that experimenting is my job :) But this time I didn't use the DEVEN register:
Change-Id: I21409adf85b70bccc30dd8e12a03ad7921544b3c
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35100 )
Change subject: mb/asrock/h110m: add missing pci devices to tree ......................................................................
mb/asrock/h110m: add missing pci devices to tree
These devices are enabled after initializing in the FSP
Change-Id: I0a15537b6ba56fcf63267641ef2219f24d25d9c4 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35100 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 1240d39..b4e6a02 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -275,6 +275,8 @@ device pci 02.0 on # Integrated Graphics Device subsystemid 0x1849 0x1912 end + device pci 04.0 on end # Thermal Subsystem + device pci 08.0 off end # Gaussian Mixture Model device pci 14.0 on # USB xHCI subsystemid 0x1849 0xa131 end
-
Angel Pons (Code Review) -
Maxim Polyakov (Code Review)
-
Patrick Georgi (Code Review)