Attention is currently required from: Arthur Heymans, Kapil Porwal, Sridhar Siricilla, Subrata Banik.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74995?usp=email )
Change subject: soc/intel/cmd/blk/cse: Implement APIs to access FW versions in CMOS
......................................................................
Patch Set 46:
(2 comments)
File src/soc/intel/common/block/cse/cse_lite_cmos.c:
https://review.coreboot.org/c/coreboot/+/74995/comment/f0cd6340_a5bc27de :
PS45, Line 103: ptr = (u32 *)(&version->cse_version);
: *ptr = *(ptr + 1) = INVALID_VERSION;
: ptr = (u32 *)(&version->ish_version);
: *ptr = *(ptr + 1) = INVALID_VERSION;
WDYT? […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/74995/comment/a3a60451_43042924 :
PS45, Line 108: /* Checksum over signature and firmware versions only */
do we need this line?
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74995?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd0ee19575683691c0a82a291e1fd3b2ffb11786
Gerrit-Change-Number: 74995
Gerrit-PatchSet: 46
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 21 Jun 2023 10:35:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment