[S] Change in coreboot[main]: CFR: Add min/max/step values and hex display flag for number options - coreboot-gerrit

18 Jan 2025


      Attention is currently required from: Filip Brozovic, Matt DeVillier, Sean Rhodes.
Angel Pons has posted comments on this change by Filip Brozovic. ( https://review.coreboot.org/c/coreboot/+/86039?usp=email )
Change subject: CFR: Add min/max/step values and hex display flag for number options
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/option/cfr.c:
https://review.coreboot.org/c/coreboot/+/86039/comment/4f37bce7_ba9406b9?usp... :
PS2, Line 123: step
...
At least in HII, a step size of 0 means the variable can't be changed with -/+ keys, which makes the […]
Ah, wasn't aware of that. I think it makes sense, yes.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/86039?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e70f1430fb1911f1ad974832f8abfe76f928ac3
Gerrit-Change-Number: 86039
Gerrit-PatchSet: 2
Gerrit-Owner: Filip Brozovic fbrozovic@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Filip Brozovic fbrozovic@gmail.com
Gerrit-Comment-Date: Sat, 18 Jan 2025 09:48:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Filip Brozovic fbrozovic@gmail.com