Attention is currently required from: Arthur Heymans, Julius Werner, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78799?usp=email )
Change subject: Use common GCD function
......................................................................
Patch Set 5:
(2 comments)
File src/drivers/analogix/anx7625/anx7625.c:
https://review.coreboot.org/c/coreboot/+/78799/comment/ff1bee96_99361f57 :
PS4, Line 157: static void anx7625_reduction_of_a_fraction(unsigned long *_a,
Can we change the types of a, b, m, n (and others) to `u32`?
Done
File src/northbridge/intel/ironlake/quickpath.c:
https://review.coreboot.org/c/coreboot/+/78799/comment/10a6b59f_0b982624 :
PS4, Line 20: static unsigned int lcm(unsigned int a, unsigned int b)
u32
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78799?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I30e4b02a9ca6a15c9bc4edcf4143ffa13a21a732
Gerrit-Change-Number: 78799
Gerrit-PatchSet: 5
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 02 Nov 2023 09:40:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment