Attention is currently required from: Arthur Heymans, Jakub "Kuba" Czapiga, Julius Werner, Jérémy Compostella, Lean Sheng Tan, Matt DeVillier, Maximilian Brune, Philipp Hug, Simon Glass, ron minnich.
Benjamin Doron has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/76591?usp=email )
Change subject: Add UPL FDT handoff
......................................................................
Patch Set 35:
(2 comments)
File src/drivers/uart/pl011.c:
https://review.coreboot.org/c/coreboot/+/76591/comment/ae4e7cd9_cda1d0a7?usp... :
PS24, Line 96: uint8_t
Are you sure this shouldn't be uint32_t?
I've checked the PL011 TRM and a Rockchip SoC TRM, because I had it on hand, and yes, this should be uint32_t.
File src/lib/upl_fdt_table.c:
https://review.coreboot.org/c/coreboot/+/76591/comment/b37bc6ad_1a6e2944?usp... :
PS24, Line 54: header.reserve_map_offset = cpu_to_be32(ALIGN_UP(dev_tree.header_size, 16));
You can change to 8 byte alignment (as per spec), but I don't see why you would remove the ALIGN_UP. […]
Ah, got it. I wasn't sure which to do, since both aligning on 8 bytes and 16 had the same effect.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76591?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36148e9de6ee992a67ec853ef5cbf1b5f83b44ae
Gerrit-Change-Number: 76591
Gerrit-PatchSet: 35
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Jincheng Li
jincheng.li@intel.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Shuo Liu
shuo.liu@intel.com
Gerrit-CC: coreboot org
coreboot.org@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 19 Feb 2025 00:51:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com