Change in coreboot[master]: soc/intel/cannonlake: Ensure bootblock disable GPIO PM configuration
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37319 )
Change subject: soc/intel/cannonlake: Ensure bootblock disable GPIO PM configuration ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37319/2/src/soc/intel/cannonlake/bo... File src/soc/intel/cannonlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/37319/2/src/soc/intel/cannonlake/bo... PS2, Line 186: soc_fill_gpio_pm_configuration I don't think we need to duplicate this function: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/cannonlake/...
Can this instead be added to a file that can be used by either stage? Also, I think we should name this function differently -- it is not just filling GPIO PM configuration, but actually performing GPIO PM configuration.
-
Furquan Shaikh (Code Review)