Change in coreboot[master]: mb/google/octopus: Add custom SAR values for Lick

[Hash Hung (Code Review)]

Hash Hung has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38508 )

Change subject: mb/google/octopus: Add custom SAR values for Lick
......................................................................

mb/google/octopus: Add custom SAR values for Lick

Lick would prefer to use different SAR values.

BUG=b:147969216
BRANCH=octopus
TEST=build

Signed-off-by: Hash.Hung 
Change-Id: Ide8e6b02b2829d5115bb755b37791d9bb04f3eee
---
M src/mainboard/google/octopus/variants/lick/Makefile.inc
A src/mainboard/google/octopus/variants/lick/mainboard.c
2 files changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/38508/1

diff --git a/src/mainboard/google/octopus/variants/lick/Makefile.inc b/src/mainboard/google/octopus/variants/lick/Makefile.inc
index 9fb63f5..152b46e 100644
--- a/src/mainboard/google/octopus/variants/lick/Makefile.inc
+++ b/src/mainboard/google/octopus/variants/lick/Makefile.inc
@@ -1,3 +1,4 @@
 bootblock-y += gpio.c

ramstage-y += gpio.c
+ramstage-y += mainboard.c
diff --git a/src/mainboard/google/octopus/variants/lick/mainboard.c b/src/mainboard/google/octopus/variants/lick/mainboard.c
new file mode 100644
index 0000000..33eb9f8
--- /dev/null
+++ b/src/mainboard/google/octopus/variants/lick/mainboard.c
@@ -0,0 +1,23 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google LLC
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <boardid.h>
+#include <ec/google/chromeec/ec.h>
+#include <sar.h>
+
+const char *get_wifi_sar_cbfs_filename(void)
+{
+	return "wifi_sar-lick.hex";
+}

[Hash Hung (Code Review)]

Hello Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38508

to look at the new patch set (#2).

Change subject: mb/google/octopus: Add custom SAR values for Lick
......................................................................

mb/google/octopus: Add custom SAR values for Lick

Lick would prefer to use different SAR values.

BUG=b:147969216
BRANCH=octopus
TEST=./util/abuild/abuild -p none -t google/octopus -x -a

Signed-off-by: Hash.Hung 
Change-Id: Ide8e6b02b2829d5115bb755b37791d9bb04f3eee
---
M src/mainboard/google/octopus/variants/lick/Makefile.inc
A src/mainboard/google/octopus/variants/lick/mainboard.c
2 files changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/38508/2

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38508 )

Change subject: mb/google/octopus: Add custom SAR values for Lick
......................................................................

Patch Set 2:

If there is only one SAR binary under this FW variant then you can just modify coreboot config to specify the file name in CBFS like - [1] in your config.lick .

[1] https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/r...

[Hash Hung (Code Review)]

Hash Hung has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38508 )

Change subject: mb/google/octopus: Add custom SAR values for Lick
......................................................................

Abandoned

Don't need it because only one SKU.