[S] Change in coreboot[master]: mb/google/brya/var/agah: Explictly program the dGPU's PCI IRQ - coreboot-gerrit

20 Sep 2022


      Attention is currently required from: Tim Wawrzynczak.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67746 )
Change subject: mb/google/brya/var/agah: Explictly program the dGPU's PCI IRQ
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/agah/variant.c:
https://review.coreboot.org/c/coreboot/+/67746/comment/f8cc7eec_c0169564 
PS1, Line 168: 	 * Right now the IRQ value (PCI_INTERRUPT_LINE) is getting
nit: for clarity, maybe include the explanation written in your commit comment here instead (It explains more clearly why we are doing this).
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/67746
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66ca3701c4c2fe5359621023b1fd45f8afd3b745
Gerrit-Change-Number: 67746
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 20 Sep 2022 18:16:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment