Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77444?usp=email )
Change subject: mb/dell: Add Latitude E6430 (Ivy Bridge)
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/dell/snb_ivb_latitude/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/77444/comment/3411b443_90ea3951 :
PS10, Line 6: /* FIXME: check this function. */
can this be removed?
Done. I removed the file, as none of those fields are used in ACPI code for this board.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77444?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I93c6622fc5da1d0d61a5b2c197ac7227d9525908
Gerrit-Change-Number: 77444
Gerrit-PatchSet: 12
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Iru Cai
mytbk920423@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 01 May 2024 20:52:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment