Attention is currently required from: Derek Huang, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
David Wu has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/87020?usp=email )
Change subject: mb/google/nissa/var/dirks: Add romstage early graphics for dirks
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/dirks/gpio.c:
https://review.coreboot.org/c/coreboot/+/87020/comment/423322e3_9d307566?usp... :
PS1, Line 170: GPP_H17
Can we avoid reconfiguration of these GPIOs in ramstage?
Remove reconfiguration of these GPIOs in ramstage, HDMI will not display. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87020?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8ab2c3a2cc72059facbbc0bba59cc480a5081a9e
Gerrit-Change-Number: 87020
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 28 Mar 2025 07:45:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com