Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35613 )
Change subject: lib/bootsplash: Fix compilation ......................................................................
lib/bootsplash: Fix compilation
Add missing include. Tested on Supermicro X11SSH-TF.
Change-Id: Id0c80ac646001a497e96cae4d48a0f09762eb936 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/lib/bootsplash.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/35613/1
diff --git a/src/lib/bootsplash.c b/src/lib/bootsplash.c index 812a3b7..8364afa 100644 --- a/src/lib/bootsplash.c +++ b/src/lib/bootsplash.c @@ -18,6 +18,7 @@ #include <console/console.h> #include <endian.h> #include <bootsplash.h> +#include <stdlib.h>
#include "jpeg.h"
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35613 )
Change subject: lib/bootsplash: Fix compilation ......................................................................
Patch Set 1: Code-Review+2
Add CONFIG_BOOTSPLASH=y to one of the configs to buildtest it?
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35613 )
Change subject: lib/bootsplash: Fix compilation ......................................................................
Patch Set 1:
Done. See CB:35615
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35613 )
Change subject: lib/bootsplash: Fix compilation ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35613 )
Change subject: lib/bootsplash: Fix compilation ......................................................................
Patch Set 1: Code-Review+1
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35613 )
Change subject: lib/bootsplash: Fix compilation ......................................................................
Patch Set 1: Code-Review+1
The same I have tested on Minnow Board MAX as well yesterday.
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35613 )
Change subject: lib/bootsplash: Fix compilation ......................................................................
lib/bootsplash: Fix compilation
Add missing include. Tested on Supermicro X11SSH-TF.
Change-Id: Id0c80ac646001a497e96cae4d48a0f09762eb936 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35613 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/lib/bootsplash.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved Name of user not set #1002476: Looks good to me, but someone else must approve
diff --git a/src/lib/bootsplash.c b/src/lib/bootsplash.c index 812a3b7..8364afa 100644 --- a/src/lib/bootsplash.c +++ b/src/lib/bootsplash.c @@ -18,6 +18,7 @@ #include <console/console.h> #include <endian.h> #include <bootsplash.h> +#include <stdlib.h>
#include "jpeg.h"
-
Arthur Heymans (Code Review) -
Name of user not set (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)