Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42423 )
Change subject: ACPI: Add framework for GNVS initialisation ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42423/4/src/acpi/Makefile.inc File src/acpi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42423/4/src/acpi/Makefile.inc@11 PS4, Line 11: y
$(CONFIG_CHROMEOS)
Done
https://review.coreboot.org/c/coreboot/+/42423/4/src/acpi/chromeos-gnvs.c File src/acpi/chromeos-gnvs.c:
https://review.coreboot.org/c/coreboot/+/42423/4/src/acpi/chromeos-gnvs.c@13 PS4, Line 13: EFCW
ECFW
Done
https://review.coreboot.org/c/coreboot/+/42423/4/src/acpi/chromeos-gnvs.c@18 PS4, Line 18: ACTIVE_ECFW_RO
Sounds good
Let's have Aaron or Furquan resolve this comment. I think the plan is to move this completely or partially under vendorcode at a later date. Maybe after this acpi-gnvs-framework topic is otherwise completed.
https://review.coreboot.org/c/coreboot/+/42423/4/src/include/acpi/acpi_gnvs.... File src/include/acpi/acpi_gnvs.h:
https://review.coreboot.org/c/coreboot/+/42423/4/src/include/acpi/acpi_gnvs.... PS4, Line 12:
double empty line
Done
-
Kyösti Mälkki (Code Review)