Attention is currently required from: Jayvik Desai, Kapil Porwal, Mac Chiang, Pranava Y N, Subrata Banik, Weimin Wu.
Paul Menzel has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/86747?usp=email )
Change subject: mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86747/comment/bd5c5808_c355a83a?usp... :
PS5, Line 10: The ALC1320 soundwire class_id = 0x01 (MIPI_CLASS_SDCA)
Sorry, I didn’t mean HDA verb, but a normal verb (noun, adjective), so it reads as a sentence. Something like below (if correct):
The ALC1320 soundwire class_id is MIPI_CLASS_SDCA (1).
https://review.coreboot.org/c/coreboot/+/86747/comment/9b6c3838_4361b058?usp... :
PS5, Line 13: TEST=emerge-fatcat coreboot
yes, 1320 acpi is probed and registered r/w success.
Please amend the commit message accordingly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86747?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie8763888810f56eb45523e3bcf7ef082900b1225
Gerrit-Change-Number: 86747
Gerrit-PatchSet: 6
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mac Chiang
mac.chiang@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Mac Chiang
mac.chiang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 31 Mar 2025 07:10:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mac Chiang
mac.chiang@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org