Attention is currently required from: V Sowmya, Martin Roth, Tim Wawrzynczak, Subrata Banik, Balaji Manigandan.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49732 )
Change subject: mb/intel/shadowmountain: Add the ramstage code
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49732/comment/935fd2f2_5dc298fe
PS3, Line 41: # Enable PCH PCIE RP 5 using CLK 1
: register "PchPcieRpEnable[4]" = "1"
: register "PcieClkSrcClkReq[1]" = "1"
: register "PcieClkSrcUsage[1]" = "0x4"
: register "PcieRpClkReqDetect[4]" =
i think this would need a rebase as per https://review.coreboot.org/c/coreboot/+/48340
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49732
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I419eecefddf9ee6e4249ada041ebeb1b78e85eb7
Gerrit-Change-Number: 49732
Gerrit-PatchSet: 3
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Fri, 05 Feb 2021 11:50:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment