Change in coreboot[master]: mb/intel/tglrvp: add Tiger Lake memory initialization support
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38998 )
Change subject: mb/intel/tglrvp: add Tiger Lake memory initialization support ......................................................................
Patch Set 5:
(59 comments)
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 70: memcpy(mem_cfg->RcompTarget, rcomp_data->rcomp_target, sizeof(rcomp_data->rcomp_target)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/spd/Hynix-H9HKNNNEBMAV-4267.spd.hex:
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 1: 23 11 11 0E 1B 21 F9 08 00 40 00 00 0A 01 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 2: 00 00 05 0F 92 54 01 00 8A 00 90 A8 90 C0 08 60 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 3: 04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 4: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 5: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 6: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 7: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 8: 00 00 00 00 00 00 00 00 00 00 00 92 00 A7 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 9: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 11: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 12: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 13: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 14: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 15: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 16: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 17: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 18: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 19: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 21: 00 00 00 00 00 56 00 00 00 20 20 20 20 20 20 20 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 22: 20 20 20 20 20 20 20 20 20 20 20 20 20 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 23: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 24: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 25: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 26: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 27: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 28: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 29: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 31: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 32: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/spd/spd.h:
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 25: #define SPD_ADDR_TABLE 0xFF please, no space before tabs
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 32: const void *dq_map; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 32: const void *dq_map; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 33: size_t dq_map_size; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 33: size_t dq_map_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 34: const void *dqs_map; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 34: const void *dqs_map; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 35: size_t dqs_map_size; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 35: size_t dqs_map_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 36: u16 rcomp_resistor; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 36: u16 rcomp_resistor; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 37: const void *rcomp_target; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 37: const void *rcomp_target; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 38: size_t rcomp_target_size; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 38: size_t rcomp_target_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/tglrvp_up3/memory.c:
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 22: return 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 22: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 29: { 0, 1, 6, 7, 3, 2, 5, 4 , /* Byte 0 */ space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 31: { 11, 12, 8, 15, 9, 14, 10, 13 , /* Byte 2 */ space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 33: { 4, 5, 3, 2, 7, 1, 0, 6 , /* Byte 4 */ space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 35: { 12, 11, 8, 13, 14, 15, 9, 10 , /* Byte 6 */ space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 38: { 11, 10, 9, 8, 12, 13, 15, 14 , /* Byte 0 */ space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 40: { 0, 7, 1, 6, 3, 5, 2, 4 , /* Byte 2 */ space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 42: { 4, 5, 6, 1, 3, 2, 7, 0 , /* Byte 4 */ space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 44: { 10, 12, 9, 15, 8, 11, 13, 14 , /* Byte 6 */ space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/38998/5/src/mainboard/intel/tglrvp/... PS5, Line 66: const struct rcomp_cfg * get_rcomp_data(void) "foo * bar" should be "foo *bar"
-
build bot (Jenkins) (Code Review)