Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38824 )
Change subject: soc/intel/apollolake: Display platform information ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38824/4/src/soc/intel/apollolake/re... File src/soc/intel/apollolake/report_platform.c:
https://review.coreboot.org/c/coreboot/+/38824/4/src/soc/intel/apollolake/re... PS4, Line 79: u32 i
Done
This was missed. I’d make all counting variables `unsigned int`.
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re... File src/soc/intel/apollolake/report_platform.c:
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re... PS6, Line 4: * Copyright (C) 2020 Intel Corporation. Remove the dot at the end.
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re... PS6, Line 103: cpu_id, cpu_type, microcode_ver.hi); Fits on one line?
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re... PS6, Line 106: aes_supported = (cpu_feature_flag & CPUID_AES) ? 1 : 0; Use true and false? Do you need a ternary operator?
-
Paul Menzel (Code Review)