Attention is currently required from: Jason Glenesk, Marshall Dawson, Julius Werner, Rob Barnes, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58962 )
Change subject: lib/prog_loaders, soc/amd/: Make payload_preload use cbfs_preload
......................................................................
Patch Set 1:
(1 comment)
File src/lib/prog_loaders.c:
https://review.coreboot.org/c/coreboot/+/58962/comment/4f2b0d36_0dd1cae1
PS1, Line 133: return;
nit: not sure why I didn't mention this first time this patch came around, but I think think this `r […]
So the initial thought was that the preload methods are all no-ops when not enabled. This makes the calling code easier. See https://source.corp.google.com/chromeos_public/src/third_party/coreboot/src/...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58962
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc521b238620ff52b8ba481cd3c10e5c4f1394bd
Gerrit-Change-Number: 58962
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 15 Nov 2021 22:20:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment