Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46602 )
Change subject: mb/clevo/l140cu: Add vboot support ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46602/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46602/5//COMMIT_MSG@15 PS5, Line 15:
the filenames look odd to me: […]
The A/B partitions are by definition updateable und thus read-write. So this doesn't add much value.
https://review.coreboot.org/c/coreboot/+/46602/5/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/fmds/vboot-roab.fmd:
https://review.coreboot.org/c/coreboot/+/46602/5/src/mainboard/clevo/cml-u/v... PS5, Line 22: RW_VPD(PRESERVE) 0x2000
result of discussion on IRQ with Tim and Matt: don't add the VPD region if we don't have concrete pl […]
Done
-
Felix Singer (Code Review)