[S] Change in coreboot[main]: soc/amd/common/block/lpc: Add ROM2 and ROM3 helper functions

[Patrick Rudolph (Code Review)]

Attention is currently required from: Ana Carolina Cabral, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.

Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86583?usp=email )

Change subject: soc/amd/common/block/lpc: Add ROM2 and ROM3 helper functions
......................................................................

Patch Set 3:

(3 comments)

File src/soc/amd/common/block/include/amdblocks/lpc.h:

https://review.coreboot.org/c/coreboot/+/86583/comment/81bc80b5_551c22ab?usp... :
PS1, Line 106: ROM_ADDRESS_RANGE3_START
> Shouldn't it be moved down after LPC_WIDEIO2_GENERIC_PORT to keep numerical order?

Done

File src/soc/amd/common/block/lpc/lpc_util.c:

https://review.coreboot.org/c/coreboot/+/86583/comment/5adff3be_2478bef6?usp... :
PS1, Line 292:  * The maxium window size is 16 MiB.
> > `'maxium' may be misspelled - perhaps 'maximum'?` […]

Done

https://review.coreboot.org/c/coreboot/+/86583/comment/e608397c_b9982080?usp... :
PS1, Line 314:  * Default at 0xfd00000000. The maxium window size is 64 MiB.
> > `'maxium' may be misspelled - perhaps 'maximum'?` […]

Done