Attention is currently required from: Jérémy Compostella, Naresh Solanki.
Angel Pons has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85639?usp=email )
Change subject: arch/x86/cpu: Add element id to struct cpu_cache_info
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/85639/comment/f0b66bbe_fba80f16?usp... :
PS1, Line 280: uint8_t
maybe 'cache_id'? or is that too redundant?
I was thinking of `unique_id`, but I'm okay with `cache_id` too.
Aside, if we're making this field a `uint16_t`, I would suggest placing it earlier for alignment reasons:
```
struct cpu_cache_info {
uint8_t type;
uint8_t level;
uint16_t cache_id;
size_t num_ways;
size_t num_sets;
size_t line_size;
size_t size;
size_t physical_partitions;
size_t num_cores_shared;
bool fully_associative;
};
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85639?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I29002931b559a05756419e0c4ec5c78586d3c3a5
Gerrit-Change-Number: 85639
Gerrit-PatchSet: 1
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Comment-Date: Wed, 29 Jan 2025 15:14:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Naresh Solanki
naresh.solanki@9elements.com