Attention is currently required from: Boris Mittelberg, Caveh Jalali, Dinesh Gehlot, Eric Lai, Ivy Jian, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tony Huang, Wisley Chen.
Paul Menzel has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86493?usp=email )
Change subject: mb/google/brya/var/agah: Separate the AGAH DPTF OEM variant
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86493/comment/e66f1473_b67c72f8?usp... :
PS2, Line 9: Use DPTF_ENABLE_OEM_VARIABLES_PROJECT_AGAH to
: separate variant Agah code, allowing each OEM to adjust
: in EC ASL accordingly.
Please re-flow for 72 characters per line. It’ll probably fit into two lines.
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/86493/comment/e11a4256_fd9861f8?usp... :
PS2, Line 383: #ifdef DPTF_ENABLE_OEM_VARIABLES_PROJECT_AGAH
: Local0 = ToInteger(EOVD) & EC_OEM_VARIABLE_DATA_MASK
: _SB.DPTF.ODUP(0, Local0)
: Local0 = _SB.DPTF.ODGT(0)
: _SB.DPTF.ODVP()
: Notify (_SB.DPTF, INT3400_ODVP_CHANGED)
: #endif
It’s common code. Please elaborate in the commit message, why the other boards not defining the macro are not impacted in their functionality.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86493?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2929eaa65a518b06f32e33cc31ae4a01bcfb77e8
Gerrit-Change-Number: 86493
Gerrit-PatchSet: 2
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 18 Feb 2025 09:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No