build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28341 )
Change subject: soc/amd/stoneyridge/enable_usbdebug.c: Update pci_ehci_dbg_set_port() ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/southbridge.h:
https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 311: #define DEBUG_PORT_MASK ( BIT(16) | BIT(17) | (BIT(18) ) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 311: #define DEBUG_PORT_MASK ( BIT(16) | BIT(17) | (BIT(18) ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 311: #define DEBUG_PORT_MASK ( BIT(16) | BIT(17) | (BIT(18) ) Macros with complex values should be enclosed in parentheses