Change in ...coreboot[master]: google/kukui: Pass reset gpio parameter to BL31

[Tristan Hsieh (Code Review)]

Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31605

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

google/kukui: Pass reset gpio parameter to BL31

To support gpio reset SoC, we need to pass the reset gpio parameter to
BL31.

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on Kukui and ATF(BL31) can get this parameter.

Change-Id: Iefa70dc0714a9283a79f97d475b07ac047f5f3b0
Signed-off-by: Tristan Shieh 
---
M src/mainboard/google/kukui/mainboard.c
1 file changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31605/1

diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c
index e1d8f5f..489762d 100644
--- a/src/mainboard/google/kukui/mainboard.c
+++ b/src/mainboard/google/kukui/mainboard.c
@@ -14,10 +14,13 @@
  */

#include <device/device.h>
+#include <soc/bl31_plat_params.h>
 #include <soc/gpio.h>
 #include <soc/mmu_operations.h>
 #include <soc/usb.h>

+#include "gpio.h"
+
 static void configure_emmc(void)
 {
    const gpio_t emmc_pin[] = {
@@ -37,10 +40,28 @@
    setup_usb_host();
 }

+static void register_reset_to_bl31(void)
+{
+	static struct bl31_gpio_param param_reset = {
+		.h = {
+			.type = PARAM_RESET,
+		},
+		.gpio = {
+			.polarity = BL31_GPIO_LEVEL_HIGH,
+			.direction = BL31_GPIO_DIR_OUT,
+		},
+	};
+
+	param_reset.gpio.index = GPIO_RESET.id;
+	register_bl31_param(&param_reset.h);
+}
+
 static void mainboard_init(struct device *dev)
 {
    configure_emmc();
    configure_usb();
+
+	register_reset_to_bl31();
 }

static void mainboard_enable(struct device *dev)

[Tristan Hsieh (Code Review)]

Hello You-Cheng Syu, Hung-Te Lin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31605

to look at the new patch set (#2).

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

google/kukui: Pass reset gpio parameter to BL31

To support gpio reset SoC, we need to pass the reset gpio parameter to
BL31.

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on Kukui and ATF(BL31) can get this parameter.

Change-Id: Iefa70dc0714a9283a79f97d475b07ac047f5f3b0
Signed-off-by: Tristan Shieh 
---
M src/mainboard/google/kukui/mainboard.c
1 file changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31605/2

[You-Cheng Syu (Code Review)]

You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31605 )

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

Patch Set 2: Code-Review+1

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31605 )

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

Patch Set 3: Code-Review+2

[Tristan Hsieh (Code Review)]

Hello Julius Werner, You-Cheng Syu, jitao shi, Hung-Te Lin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31605

to look at the new patch set (#6).

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

google/kukui: Pass reset gpio parameter to BL31

To support gpio reset SoC, we need to pass the reset gpio parameter to
BL31.

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on Kukui and ATF(BL31) can get this parameter.

Change-Id: Iefa70dc0714a9283a79f97d475b07ac047f5f3b0
Signed-off-by: Tristan Shieh 
---
M src/mainboard/google/kukui/mainboard.c
1 file changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31605/6

[Tristan Hsieh (Code Review)]

Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31605 )

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

Patch Set 6:

Since audio related CL(https://review.coreboot.org/#/c/coreboot/+/32459/) has been merged, rebase and fix the conflict of mainboard.c.

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31605 )

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

Patch Set 6: Code-Review+2

[jitao shi (Code Review)]

jitao shi has uploaded a new patch set (#8) to the change originally created by Tristan Hsieh. ( https://review.coreboot.org/c/coreboot/+/31605 )

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

google/kukui: Pass reset gpio parameter to BL31

To support gpio reset SoC, we need to pass the reset gpio parameter to
BL31.

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on Kukui and ATF(BL31) can get this parameter.

Change-Id: Iefa70dc0714a9283a79f97d475b07ac047f5f3b0
Signed-off-by: Tristan Shieh 
---
M src/mainboard/google/kukui/mainboard.c
1 file changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31605/8

Change in coreboot[master]: google/kukui: Pass reset gpio parameter to BL31

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#11) to the change originally created by Tristan Hsieh. ( https://review.coreboot.org/c/coreboot/+/31605 )

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

google/kukui: Pass reset gpio parameter to BL31

To support gpio reset SoC, we need to pass the reset gpio parameter to
BL31.

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on Kukui and ATF(BL31) can get this parameter.

Change-Id: Iefa70dc0714a9283a79f97d475b07ac047f5f3b0
Signed-off-by: Tristan Shieh 
---
M src/mainboard/google/kukui/mainboard.c
1 file changed, 19 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31605/11

Change in coreboot[master]: google/kukui: Pass reset gpio parameter to BL31

[Tristan Hsieh (Code Review)]

Hello Yu-Ping Wu, Julius Werner, You-Cheng Syu, jitao shi, Hung-Te Lin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31605

to look at the new patch set (#12).

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

google/kukui: Pass reset gpio parameter to BL31

To support gpio reset SoC, we need to pass the reset gpio parameter to
BL31.

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on Kukui and ATF(BL31) can get this parameter.

Change-Id: Iefa70dc0714a9283a79f97d475b07ac047f5f3b0
Signed-off-by: Tristan Shieh 
---
M src/mainboard/google/kukui/mainboard.c
1 file changed, 17 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31605/12

Change in coreboot[master]: google/kukui: Pass reset gpio parameter to BL31

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31605 )

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

Patch Set 13:

Rebased on top of master so it should compile.

Change in coreboot[master]: google/kukui: Pass reset gpio parameter to BL31

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31605 )

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

Patch Set 13: Code-Review+2

Change in coreboot[master]: google/kukui: Pass reset gpio parameter to BL31

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/31605 )

Change subject: google/kukui: Pass reset gpio parameter to BL31
......................................................................

google/kukui: Pass reset gpio parameter to BL31

To support gpio reset SoC, we need to pass the reset gpio parameter to
BL31.

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on Kukui and ATF(BL31) can get this parameter.

Change-Id: Iefa70dc0714a9283a79f97d475b07ac047f5f3b0
Signed-off-by: Tristan Shieh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31605
Tested-by: build bot (Jenkins) 
Reviewed-by: Hung-Te Lin 
---
M src/mainboard/google/kukui/mainboard.c
1 file changed, 17 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Hung-Te Lin: Looks good to me, approved

diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c
index f34be6f..7b00d94 100644
--- a/src/mainboard/google/kukui/mainboard.c
+++ b/src/mainboard/google/kukui/mainboard.c
@@ -14,6 +14,7 @@
  */

#include <assert.h>
+#include <bl31.h>
 #include <boardid.h>
 #include <bootmode.h>
 #include <cbfs.h>
@@ -30,8 +31,11 @@
 #include <soc/usb.h>
 #include <string.h>

+#include "gpio.h"
 #include "panel.h"

+#include <arm-trusted-firmware/include/export/plat/mediatek/common/plat_params_exp.h>
+
 static void configure_emmc(void)
 {
    const gpio_t emmc_pin[] = {
@@ -172,6 +176,17 @@
    return true;
 }

+static void register_reset_to_bl31(void)
+{
+	static struct bl_aux_param_gpio param_reset = {
+		.h = { .type = BL_AUX_PARAM_MTK_RESET_GPIO },
+		.gpio = { .polarity = ARM_TF_GPIO_LEVEL_HIGH },
+	};
+
+	param_reset.gpio.index = GPIO_RESET.id;
+	register_bl31_aux_param(&param_reset.h);
+}
+
 static void mainboard_init(struct device *dev)
 {
    if (display_init_required()) {
@@ -186,6 +201,8 @@
    configure_emmc();
    configure_usb();
    configure_audio();
+
+	register_reset_to_bl31();
 }

static void mainboard_enable(struct device *dev)