Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Christian Walter, Tim Wawrzynczak, Angel Pons, Lean Sheng Tan, David Milosevic.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68756 )
Change subject: soc/intel/alderlake: Add IBECC
......................................................................
Patch Set 7:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68756/comment/97eda0ba_1d710775
PS5, Line 7: src/
Drop `src/`
Done
https://review.coreboot.org/c/coreboot/+/68756/comment/eb7c76a3_7fd14bcd
PS5, Line 7: Alderlake
Alder Lake, but it’s redundant as it’s in the prefix.
Done
https://review.coreboot.org/c/coreboot/+/68756/comment/899e33fa_423ea5f8
PS5, Line 10: Board
Without capitalizing `b`? +1
Done
https://review.coreboot.org/c/coreboot/+/68756/comment/1abc0aca_557fd1a9
PS5, Line 11:
Please elaborate. Is the FSP doing that? […]
Done
Patchset:
PS5:
Should something be logged, when this is enabled?
Done
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/68756/comment/c00d04ae_a7535356
PS5, Line 372: !!config->ibecc.enable
It's a `bool` already
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68756
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cc2ed6defa1223aa422b9b0d8145f8f8b3dd12e
Gerrit-Change-Number: 68756
Gerrit-PatchSet: 7
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Wed, 02 Nov 2022 10:54:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment