Attention is currently required from: Julius Werner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50247 )
Change subject: Documentation: Codify some guidelines for headers and chain-including ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Sorry for the useless comments yesterday. I was indirectly pointed […]
About alphabetical order: I wouldn't say I hate it. Whenever it is still recognizable, I try to maintain it (as I try to do with any local style originalities if I notice them).
However, there is this "still". Alphabetical order seems to degrade faster than the best organic compost. I'm not sure if style guidelines can fix that. And automatically sorting also doesn't seem like an option because sometimes the order matters.
So to me, alphabetical order just means one thing: pain for everyone. * Pain for the original authors, because they get upset when they see it degrade. * Pain for reviewers, because there is more to check. * Pain for people who adapt the code later, because they need to maintain it. * More pain for reviewers, because at some point somebody will write patches in the ridiculous attempt to restore the order. * Pain for empathetic people who see the pointless circling. (* Pain for me because I like to order things differently: standard/more generic includes first, more specific includes later, ending with includes in the local directory, i.e. #include "some.h")
Some people have other preferences. I know some don't like it when lists look too ragged. Though, I'm not sure if anybody in this community cares. ;) After all, for me the best solution is to try (hard for me too) to not care. Because technically, the order shouldn't matter. And if nobody would care, there would be no cleanup patches! what a perfect world! :D