Attention is currently required from: Derek Huang, Paul Menzel, Robert Chen, Shou-Chieh Hsu.
Karthik Ramasubramanian has posted comments on this change by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/84953?usp=email )
Change subject: mb/google/dedede/var/drawcia: Correct board version in variant_devicetree_update ......................................................................
Patch Set 11:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84953/comment/a45c1a08_fa901857?usp... : PS11, Line 11: more board added after that. Specific Drawper board version as 0xa, 0xb and 0xf.
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
File src/mainboard/google/dedede/variants/drawcia/ramstage.c:
https://review.coreboot.org/c/coreboot/+/84953/comment/6c113bdc_2efa70a9?usp... : PS11, Line 37: /* Remove power IC after board version 0xc */ Please move this comment above the if condition. Also please add a comment regarding which Draw* variants have board version > b? Drawlat, Drawman, Drawcia, Drawper, anything else etc.?
https://review.coreboot.org/c/coreboot/+/84953/comment/e48539b5_06fd0fbf?usp... : PS11, Line 42: /* board version 0xa, 0xb , 0xf is for drawper unit */ Please move this comment above the if condition. Also please rephrase the comment as: `/* Board version 0xa, 0xb and 0xf are for Drawper units */`