Attention is currently required from: V Sowmya, Shahina Shaik, Haribalaraman Ramasubramanian, Paul Menzel, Sridhar Siricilla, Julius Werner, Balaji Manigandan.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69221 )
Change subject: security/vboot: Fix different size operands in bitwise operation
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Please see Julius' comment in https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_referen...:
Let's not put these casts here. They are unnecessary for now, because we haven't allocated bit 32 or higher yet, so they'll always be 0 anyway, and once we do we'll have to stop using an enum anyway because enums can't be larger than 32-bit (I think?). So at that point we'll have to represent them as macros or something and then we should just define them ULL to begin with.
We definitely don't want to be in a situation where you have to put this cast here or otherwise something is gonna silently break (because sooner or later someone would make that mistake), so we wouldn't build a system that requires that. Then there's no point in having the casts here either. (If you want to be extra proactive, feel free to already rewrite the field definitions now.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifecd5de843bd0229c0cab758d4a641889b4bffd6
Gerrit-Change-Number: 69221
Gerrit-PatchSet: 2
Gerrit-Owner: Shahina Shaik
shahina.shaik@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shahina Shaik
shahina.shaik@intel.corp-partner.google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Shahina Shaik
shahina.shaik@intel.com
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Shahina Shaik
shahina.shaik@intel.corp-partner.google.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Mon, 07 Nov 2022 08:08:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment