Attention is currently required from: Stefan Ott, Felix Singer, Patrick Rudolph, Jonathan Zhang, Nick Vaccaro, Arthur Heymans, Andrey Petrov, Piotr Król, Nico Huber, Sean Rhodes, Michał Żygowski, Johnny Lin, Christian Walter, Werner Zeh, Alexander Couzens, Yu-Ping Wu, Tim Chu, Frans Hendriks, Tristan Corrick, Jeremy Soller, Julius Werner, Angel Pons, Michael Niewöhner, Tim Crawford, Maxim Polyakov, Tim Wawrzynczak.
Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63424 )
Change subject: tpm: Refactor TPM Kconfig dimensions
......................................................................
Patch Set 16:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63424/comment/4b375c8f_81217f5b
PS13, Line 7: Kconfig
Well, the change isn't solely about Kconfig anymore, but also touches code. […]
Yes, I feel that the changes required to introduce chip.c files are balooning, and Jenkins is currently showing many linker errors. I need to land this refactoring (accepting new Ti50 identification), before I can land the Ti50 change to start presenting the new identification, and I want to do the latter before an upcoming FSI of Ti50 firmware.
I think I am going to split this CL into a pure Kconfig refactoring, and then another CL that introduces chip.c files, and rectifies the conditions under which that code is compiled and linked. Stay tuned.
File src/drivers/crb/chip.c:
https://review.coreboot.org/c/coreboot/+/63424/comment/114383e7_91c268a0
PS13, Line 17: .acpi_fill_ssdt = crb_tpm_fill_ssdt,
The definitions of these two functions need to move into this file too, otherwise you have missing r […]
Done
File src/drivers/pc80/tpm/chip.c:
https://review.coreboot.org/c/coreboot/+/63424/comment/62e353b6_85482e14
PS13, Line 14: u8 value = read8(TIS_REG(locality, TIS_REG_INT_VECTOR));
Jenkins complains that you don't have TIS_REG() in this context. […]
Many of these small inline functions are being used both from the methods now in the new chip.c file, as well as methods remaining in tis.c. I have created a new tis.h to contain shared macros and inline function definitions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63424
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4656b2b90363b8dfd008dc281ad591862fe2cc9e
Gerrit-Change-Number: 63424
Gerrit-PatchSet: 16
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Stefan Ott
coreboot@desire.ch
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: siemens-bot
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Ott
coreboot@desire.ch
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 19 Apr 2022 17:50:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment