Attention is currently required from: Jason Nien, Martin Roth, Raul Rangel.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79793?usp=email )
Change subject: mb/google/guybrush: Update DDI descriptor definition ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/79793/comment/8a36ee70_fde7b878 : PS2, Line 36: .connector_type = DDI_EDP, : .aux_index = DDI_AUX1, : .hdp_index = DDI_HDP1
Optional: Can we `#define` these like we did for the DXIO descriptors? We could then make the varian […]
We can. I wasn't sure if there was a lot of benefit in this case, but wanted to leave the option there if it was beneficial in the future. My assumption from the logic in the Dewatt/Guybrush variants is that some SKU's for those models do have an HDMI port, so we would still be defining it the default way and overriding. I could be wrong. WDYT?