Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35403 )
Change subject: soc/intel/common/basecode: Implement CSE update flow ......................................................................
Patch Set 86:
(16 comments)
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... File Documentation/soc/intel/cse_fw_update/cse_fw_update.md:
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 6: CSE and PMC cooperate providing platform services during boot and other
"The CSE and PMC cooperate by providing... […]
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 37: current boot partition which is : currently being used by CSE to boot, next boot partition which will be used : by CSE to boot on next reset, and number of boot partitions available in : the CSE region.
suggestion: […]
Agreed.
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 52: partitio
partition
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 53: CSE loadable
CSE-loadable
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 61: select next partition on next boot
suggestion: "select the partition for the next boot"
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 70:
extra space
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 81: Downgrade
downgrade
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 89: the
not necessary
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 91: require
be required
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 92: o
...vary from one...
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 92: platforn
platform
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 93: RW CBFSes if required.
in the RW CBFS region.
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 93: require
be required
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 103:
tabs to line up with previous line?
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 123:
extra space
Done
https://review.coreboot.org/c/coreboot/+/35403/85/Documentation/soc/intel/cs... PS85, Line 125:
extra space
Done
-
Sridhar Siricilla (Code Review)