Change in coreboot[master]: sc7180: Add QUPv3 FW load & config

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 )

Change subject: sc7180: Add QUPv3 FW load & config
......................................................................

Patch Set 44:

(3 comments)

https://review.coreboot.org/c/coreboot/+/35499/40/src/soc/qualcomm/sc7180/in... 
File src/soc/qualcomm/sc7180/include/soc/qupv3_config.h:

https://review.coreboot.org/c/coreboot/+/35499/40/src/soc/qualcomm/sc7180/in... 
PS40, Line 54: #define QUPV3_UART_SRC_HZ					7372800
> I'm not sure I understand what you mean. […]

*ping*

This issue is still outstanding.

https://review.coreboot.org/c/coreboot/+/35499/44/src/soc/qualcomm/sc7180/qu... 
File src/soc/qualcomm/sc7180/qupv3_config.c:

https://review.coreboot.org/c/coreboot/+/35499/44/src/soc/qualcomm/sc7180/qu... 
PS44, Line 21: 							unsigned int mode)
Why did the mode get added back here? Please explain what you're changing. The way you have it now UARTs are just always FIFO and I2C and SPI are always MIXED... in that case you don't need an extra mode parameter, you can just infer it from protocol.

https://review.coreboot.org/c/coreboot/+/35499/44/src/soc/qualcomm/sc7180/qu... 
PS44, Line 30: 	const char *filename[] = {
> char * array declaration might be better as static const

I think you should follow this advice, it leads to slightly better code generation.