Change in coreboot[master]: src/acpi/acpigen_usb.c: Fix Memory leak error - coreboot-gerrit

25 Mar 2022


      Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
vaibhav has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62968 )
Change subject: src/acpi/acpigen_usb.c: Fix Memory leak error
......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpigen_usb.c:
https://review.coreboot.org/c/coreboot/+/62968/comment/526f84e0_86d5f95d 
PS1, Line 89: free(fresh);
...
The memory "leak" is intended; the pointer returned from `strdup` is intended to outlive this functi […]
Oh I see, this makes the error detected by scan-build trivial
should I close this PR?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifed611bd0b9c1da3678386bff33bca3eac0311b4
Gerrit-Change-Number: 62968
Gerrit-PatchSet: 1
Gerrit-Owner: vaibhav vrockz747@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 25 Mar 2022 11:24:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment