Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79793?usp=email )
Change subject: mb/google/guybrush: Update DDI descriptor definition ......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/mainboard/google/guybrush/variants/dewatt/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79793/comment/904958ce_66c8a8e3 : PS3, Line 8: bootblock-y += variant.c Surprised we need this in bootblock.
File src/mainboard/google/guybrush/variants/nipperkin/variant.c:
https://review.coreboot.org/c/coreboot/+/79793/comment/0ffef616_ee6243ec : PS3, Line 7: true I'm honestly surprised the same logic for guybrush and dewatt doesn't apply here. It seems to be an SoC limitation. We probably just got lucky because we didn't ship any of these lower powered SoCs?