Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38318 )
Change subject: soc/intel/skylake: Call mainboard ACPI sleep methods
......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6:
Did already have a mainboard level MPTS/MWAK change on top for skylake mainboard? Otherwise the code will not do anything.
Mainboards would implement MPTS/MWAK methods if they needed to, I imagine. The mainboard that I've mostly completed a port for is going to be using it, so I thought I'd try getting this edit into the SoC-level ACPI code.
Then that will be more than just skylake, what about all the other SOC? If put two commits together to review will be better.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38318
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I969d92c7445b01964d92d28b21f6667614ea82e7
Gerrit-Change-Number: 38318
Gerrit-PatchSet: 6
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-Comment-Date: Mon, 13 Jan 2020 04:35:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment