Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87076?usp=email )
Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for HDA ......................................................................
mb/starlabs/starbook/adl_n: Tidy GPIO comments for HDA
This is a non-functional change, and only makes the GPIOs easier to read.
Change-Id: Ib40431a24037535e7c4d1bc49a5ae50576b62e33 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/87076 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 7 insertions(+), 11 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 2bcc4ac..4fdabc5 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -57,6 +57,13 @@ PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* HDMI Data */ PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* TCP0 Hot Plug */
+ /* High-Definition Audio */ + PAD_CFG_NF(GPP_R0, NATIVE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_R1, NATIVE, DEEP, NF1), /* Sync */ + PAD_CFG_NF(GPP_R2, NATIVE, DEEP, NF1), /* Data Output */ + PAD_CFG_NF(GPP_R3, NATIVE, DEEP, NF1), /* Data Input */ + PAD_CFG_NF(GPP_R4, NATIVE, DEEP, NF1), /* Reset */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -418,17 +425,6 @@ /* T15: Not Connected */ PAD_NC(GPP_T15, NONE),
- /* R0: HDA BCLK */ - PAD_CFG_NF(GPP_R0, NATIVE, DEEP, NF1), - /* R1: HDA SYNC */ - PAD_CFG_NF(GPP_R1, NATIVE, DEEP, NF1), - /* R2: HDA SDO */ - PAD_CFG_NF(GPP_R2, NATIVE, DEEP, NF1), - /* R3: HDA SDI */ - PAD_CFG_NF(GPP_R3, NATIVE, DEEP, NF1), - /* R4: HDA Reset */ - PAD_CFG_NF(GPP_R4, NATIVE, DEEP, NF1), - /* R5: MiPi Cam Reset */ PAD_NC(GPP_R5, NONE), /* R6: Not Connected */ PAD_NC(GPP_R6, NONE),