Attention is currently required from: Angel Pons, Bill XIE, Nicholas Chin.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85413?usp=email )
Change subject: mb/asus/p8z77-v: Attempt to correctly route PCIe lanes
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS6:
Bill, since I also removed the PP/OD setting around GPIO bank 7 which overlaps with the 3 reset output pins, please watch for regressions around rebooting.
File src/mainboard/asus/p8x7x-series/variants/p8z77-v/early_init.c:
https://review.coreboot.org/c/coreboot/+/85413/comment/56656349_9d902c75?usp... :
PS2, Line 77: {7, 34, 20, -1}
The `overridetree.cb` still specifies `drq 0xe4 = 0xfc` for `device pnp 2e. […]
Fix in. Thanks for the catch.
Goes to show that I need more sleep. -.-
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85413?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If41197a1f817a48c209d25fc1ae461ec97ccf16c
Gerrit-Change-Number: 85413
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Thu, 30 Jan 2025 14:59:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Comment-In-Reply-To: Keith Hui
buurin@gmail.com